Repository navigation
MAINT: Chain exceptions in npyio.py - #16218
smitgajjar wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Thanks for taking a look! It looks like a few of these changes overlap with some changes proposed in #16121 . I will ping the author there to clarify the status and minimize duplication.
In the mean time, some proposed changes related to exception chaining in npyio.py were already reviewed in #15731. I didn't look too carefully, but it might be worthwhile to see if any of the review comments there apply to the proposed changes here.
|
Note that one comment from #15731 applies here - it would be an aid to reviewers if you were able to provide quick examples that raise the exceptions you propose to change. This isn't necessary, but would likely speed the review process! |
I didn't know, this was covered in that PR. I think it will be better for that author to continue! Hence, closing this now!
Thanks, will be careful about that in the next similar PR |
3 participants
This PR is related to the issue #15986.