Repository navigation
BUG: Fix small issues found with pytest-leaks - #18670
Merged
Merged
Conversation
Member
Author
|
I had not done a good pytest-leaks in a while. I still got one running (since I restarted after I found these), so some small things might still crop up, although it doesn't have stop merging this. |
seberg
force-pushed
the
small-pytest-leaks-fixes
branch
from
March 23, 2021 19:57
4ece8c1 to
cc3f321
Compare
charris
reviewed
Mar 23, 2021
Member
There was a problem hiding this comment.
This is causing problems on windows. Try data.tofile(tmp). Windows only allows a single process to access an open file and I suspect that is the problem.
Member
Author
There was a problem hiding this comment.
Thanks! Well, I tried with TemporaryDirectory and just fixed the actual filename as a file inside that directory... That seems to work fine, lets see what windows thinks.
Maybe using tmp directly is nicer, but then I have to deal with seek(0) also...
None of these are particularly worrying as they either usually only leak reference (and not memory) or appear in rare or almost impossible error-paths, or are limited to the tests. Unfortunately, this PR will not apply to 1.20.x, due to small changes in the overrides.
seberg
force-pushed
the
small-pytest-leaks-fixes
branch
from
March 23, 2021 21:22
cc3f321 to
bbc07e7
Compare
Member
|
Thanks Sebastian. |
seberg
added a commit
to seberg/numpy
that referenced
this pull request
Mar 23, 2021
None of these are particularly worrying as they either usually only leak reference (and not memory) or appear in rare or almost impossible error-paths, or are limited to the tests. Unfortunately, this PR will not apply to 1.20.x, due to small changes in the overrides. Backport of numpygh-18670 (with two small differences)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these are particularly worrying as they either usually only
leak reference (and not memory) or appear in rare or almost impossible
error-paths, or are limited to the tests.
Unfortunately, this PR will not apply to 1.20.x, due to small changes
in the overrides.
The first override fix has to be done equivalently to the second one for backporting. I can open a backport PR once this is merged.