Skip to content

TST: remove obsolete TestF77Mismatch - #20457

Merged
rgommers merged 1 commit into
numpy:mainfrom
h-vetinari:g77
Nov 26, 2021
Merged

rgommers merged 1 commit into
numpy:mainfrom
h-vetinari:g77

Conversation

@h-vetinari

Copy link
Copy Markdown
Contributor

Removes a test that is not necessary anymore since g77 is gone (and it fails in certain situations like when run through emulation in conda-forge CI), as discussed in #20445.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Nov 24, 2021
@charris charris added this to the 1.22.0 release milestone Nov 24, 2021
@charris

charris commented Nov 24, 2021

Copy link
Copy Markdown
Member

That circleci error has turned up before, but doesn't seem to persist after merge. If you are not branched from main HEAD, I'm curious if a rebase would have an effect.

@h-vetinari

Copy link
Copy Markdown
Contributor Author

If you are not branched from main HEAD, I'm curious if a rebase would have an effect.

Sorry, I had messed up my branches before pushing. 😅

Should now be rebased correctly!

@rgommers rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @h-vetinari

@rgommers
rgommers merged commit 71eb742 into numpy:main Nov 26, 2021
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Nov 27, 2021
@charris charris removed this from the 1.22.0 release milestone Nov 27, 2021
@h-vetinari
h-vetinari deleted the g77 branch November 28, 2021 22:31
h-vetinari added a commit to regro-cf-autotick-bot/numpy-feedstock that referenced this pull request Jan 1, 2022
- test_sincos_float32 taken care of in numpy/numpy#20274
- TestF77Mismatch removed upstream in numpy/numpy#20457
- test_unary_PyUFunc_O_O_method_full fixed in 1.22 (numpy/numpy#19926)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants