Repository navigation
Conversation
…gth must be positive', omitting the redundant 'if specified'.
Member
Contributor
Author
|
Thanks Chuck -- if you get a chance, can you close ticket #1595 on Trac? I tried but it won't let me modify the status. |
fangerer
pushed a commit
to hpyproject/numpy-hpy
that referenced
this pull request
Jul 7, 2022
Merge in numpy-hpy from ss/full-init to labs-hpy-port * commit '9ccee95b356a020b19a807e329befba81ec29957': Comment out datetime capsule import Port PyArray_UpdateFlags Comment out initialization of the legacy global PyObject variables and weakreflist Use HPyGlobal instead of the legacy global PyObject where applicable, ignore init of Intp and UIntp array types
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
doc: Fix readme errors
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a resubmission of this pull request taking into account Chuck's comment about the error message. I'm not sure if there's a way to add commits to a pull request, I couldn't find it; if there is I apologize for opening a second one.
This is an old patch filed as ticket 1595. Robert Kern gave a tentative +1 to this feature on the mailing list, so I went ahead and implemented it.