Repository navigation
Fix stride_stricks.as_strided function for object arrays - #4408
Conversation
Currently, calling as_strided for object array results in 'TypeError: Cannot change data-type for object array.'. Fix so that dtype of new array is only set for void dtype, as originally intended.
|
I'm going to assume you picked the right PR to merge :) anything still missing? I wanted to start the windows builds now. |
|
@juliantaylor I hope so too ;) There was still a bug in the other and my main reservation here was not noticing |
Fix stride_stricks.as_strided function for object arrays
|
What about #4146? |
|
Documentation still needs an update for this one. |
|
NVM, this one didn't have an issue. |
|
I don't have the concentration left to backport 4146 properly today, so either we skip it, add it post rc or delay rc until someone does it. |
|
I can sympathize with code burnout :0 If the backport is complicated, let's skip it. I get the impression you already made a quick pass at it. I was planning on making the branch tomorrow, would you prefer today? |
|
I guess I can wait until tomorrow |
|
OK, I'll do it tomorrow, or maybe this evening. |
3 participants
Currently, calling as_strided for object array results in 'TypeError: Cannot change data-type for object array.'. Fix so that dtype of new array is only set for void dtype, as originally intended.