Skip to content

TST: check for best-effort parsing in foreign locales - #6264

Merged
charris merged 3 commits into
numpy:masterfrom
aarchiba:longdouble_improvements
Aug 31, 2015
Merged

charris merged 3 commits into
numpy:masterfrom
aarchiba:longdouble_improvements

Conversation

@aarchiba

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread numpy/core/tests/test_longdouble.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I didn't expect that, I would have expected an error. I assume what is being checked is that , is not handled as the radix character?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how fromstring normally "handles" invalid input. But if , is the decimal marker in your locale and you're in python 2.6 and you don't have strtold_l, as @pv points out, you don't get the 1 either.

charris added a commit that referenced this pull request Aug 31, 2015
TST: check for best-effort parsing in foreign locales
@charris
charris merged commit d750cba into numpy:master Aug 31, 2015
@charris

charris commented Aug 31, 2015

Copy link
Copy Markdown
Member

Thanks Anne. I notice you don't have commit rights, they got lost in the move to github. Do you want them back?

@aarchiba

aarchiba commented Sep 1, 2015

Copy link
Copy Markdown
Contributor Author

The pull request workflow makes them a lot less necessary, and I think I need to get more used to the numpy coding style before I could approve any, but I'm willing to help when I have time. So if you think it would be useful, sure.

@charris

charris commented Sep 2, 2015

Copy link
Copy Markdown
Member

I set you an invitation. If nothing else you are on the growing developers emeritus team;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants