Repository navigation
BUG: fix for issue#7835 (ma.median of 1d) - #7911
Merged
Merged
Conversation
Member
|
Looks good to me, will merge in a bit. Thanks @skwbc ! |
Member
|
@ahaldane Mind if I merge? |
Member
|
@charris I was just about to, I just wanted to get the backport done first |
Member
|
I went ahead with it :) Thanks @skwbc |
Member
|
Great, thanks Allan. |
charris
added a commit
that referenced
this pull request
Aug 8, 2016
Backport #7911: BUG: fix for issue#7835 (ma.median of 1d)
| return masked_array(np.median(getdata(a, subok=True), axis=axis, | ||
| out=out, overwrite_input=overwrite_input, | ||
| keepdims=keepdims), copy=False) | ||
| if not hasattr(a, 'mask'): |
Contributor
There was a problem hiding this comment.
why was the count_nonzero removed?
its performance impact is practically zero but the gain on empty mask is huge
Contributor
Author
There was a problem hiding this comment.
I would like to have simplified the if-condition (that is, MaskedArray or others), and I just didn't know that np.median is much faster than np.ma.extras._median.
So, we should add or np.count_nonzero(a.mask) == 0 here.
Should I make pull request?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed bugs for #7835.
I used ma.extras._median for MaskedArray, because it works properly for 1D and 0D MaskedArray.
And, I added many tests for types of outputs of ma.median.