Repository navigation
DOC: warn that dtype.descr is only for use in PEP3118 - #8174
Merged
Merged
Conversation
Member
|
Thanks Allan. |
Member
|
This doesn't look right to me - PEP3118 doesn't say anything about |
eric-wieser
reviewed
Nov 18, 2018
|
|
||
| The format is that required by the 'descr' key in the | ||
| `__array_interface__` attribute. | ||
| PEP3118 `__array_interface__` attribute. |
Member
There was a problem hiding this comment.
__array_interface__ is defined as part of https://docs.scipy.org/doc/numpy-1.15.1/reference/arrays.interface.html, not PEP3118.
Member
Author
There was a problem hiding this comment.
Hmm, OK, I may have misunderstood.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just makes the description of
dtype.descra little scarier so people don't use it when they shouldn't.See for example #7790 #8160, also problems like #2215.