Repository navigation
Conversation
The basic_leak_checker validation layer tracked zeEventCreate and the deprecated zexCounterBasedEventCreate2 extension for event create/destroy leak detection, but not the core zeEventCounterBasedCreate API added in spec v1.15. Applications migrating from the deprecated extension to the core API saw false-positive LEAK reports because zeEventDestroy calls were counted while the corresponding create calls were not. Add zeEventCounterBasedCreate to the tracked create/destroy set and implement its Epilogue hook to count successful calls. Fixes: oneapi-src#512 Fixes: LZL-2723 Signed-off-by: Lukasz Dorau <[email protected]>
pbalcer
approved these changes
Sep 14, 2026
Contributor
Author
|
The scorecard CI job failed because of "Error: Docker pull failed with exit code 1". |
Jemale
approved these changes
Sep 14, 2026
Contributor
Author
|
@Jemale Could you restart the scorecard CI job ? https://github.com/oneapi-src/level-zero/actions/runs/34830573084/job/103932683337?pr=513 |
Contributor
|
I restarted it and it failed again, @rwmcguir it looks like there's an issue with the scorecard job. Can we merge without it until it is fixed? |
rwmcguir
approved these changes
Sep 15, 2026
rwmcguir
left a comment
rwmcguir
left a comment
Contributor
There was a problem hiding this comment.
I've confirmed these are hand written files, i.e. not part of the auto-gen so change looks good.
Contributor
|
As for the Scorecard it is not critical to our code, uncertain why it's failing but this is not due to code quality. |
ldorau
deleted the
Track_zeEventCounterBasedCreate_in_basic_leak_checker
branch
September 16, 2026 06:20
Contributor
Author
|
@rwmcguir Please include it in the next public release |
ldorau
added a commit
to ldorau/llvm
that referenced
this pull request
Sep 24, 2026
v1.34.0 adds tracking of zeEventCounterBasedCreate in basic_leak_checker (oneapi-src/level-zero#513), which is required for the counter-based-event leak-check E2E tests to pass once the L0 v2 adapter switches to calling the core zeEventCounterBasedCreate API (see PR intel#23154) instead of the deprecated zexCounterBasedEventCreate2 extension. Without this bump, the leak checker undercounts counter-based event creations and reports a false negative-leak mismatch. Bumps both the CI-installed loader package version (devops/dependencies.json) and the FetchContent-built loader used when SYCL_UR_FORCE_FETCH_LEVEL_ZERO is set (unified-runtime/cmake/FetchLevelZero.cmake), along with the matching pkg-config minimum version for the preinstalled-loader detection path.
ldorau
added a commit
to ldorau/llvm
that referenced
this pull request
Sep 25, 2026
v1.34.0 adds tracking of zeEventCounterBasedCreate in basic_leak_checker (oneapi-src/level-zero#513), which is required for the counter-based-event leak-check E2E tests to pass once the L0 v2 adapter switches to calling the core zeEventCounterBasedCreate API (see PR intel#23154) instead of the deprecated zexCounterBasedEventCreate2 extension. Without this bump, the leak checker undercounts counter-based event creations and reports a false negative-leak mismatch. Bumps both the CI-installed loader package version (devops/dependencies.json) and the FetchContent-built loader used when SYCL_UR_FORCE_FETCH_LEVEL_ZERO is set (unified-runtime/cmake/FetchLevelZero.cmake), along with the matching pkg-config minimum version for the preinstalled-loader detection path.
ldorau
added a commit
to ldorau/llvm
that referenced
this pull request
Sep 28, 2026
v1.34.0 adds tracking of zeEventCounterBasedCreate in basic_leak_checker (oneapi-src/level-zero#513), which is required for the counter-based-event leak-check E2E tests to pass once the L0 v2 adapter switches to calling the core zeEventCounterBasedCreate API (see PR intel#23154) instead of the deprecated zexCounterBasedEventCreate2 extension. Without this bump, the leak checker undercounts counter-based event creations and reports a false negative-leak mismatch. Bumps both the CI-installed loader package version (devops/dependencies.json) and the FetchContent-built loader used when SYCL_UR_FORCE_FETCH_LEVEL_ZERO is set (unified-runtime/cmake/FetchLevelZero.cmake), along with the matching pkg-config minimum version for the preinstalled-loader detection path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic_leak_checker validation layer tracked zeEventCreate and the
deprecated zexCounterBasedEventCreate2 extension for event
create/destroy leak detection, but not the core zeEventCounterBasedCreate
API added in spec v1.15. Applications migrating from the deprecated
extension to the core API saw false-positive LEAK reports because
zeEventDestroy calls were counted while the corresponding create calls
were not.
Add zeEventCounterBasedCreate to the tracked create/destroy set and
implement its Epilogue hook to count successful calls.
Fixes: #512
Fixes: LZL-2723
Ref: intel/llvm#23154