Skip to content

[release-v1.7][SRVKS-999] Add probes to all deployments - #176

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.7from
skonto:probes_for_all_1.7
Feb 21, 2023
Merged

openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.7from
skonto:probes_for_all_1.7

Conversation

@skonto

@skonto skonto commented Feb 21, 2023

Copy link
Copy Markdown

@openshift-ci
openshift-ci Bot requested review from alanfx and mgencur February 21, 2023 11:11
@skonto

skonto commented Feb 21, 2023

Copy link
Copy Markdown
Author

/assign @ReToCode

@ReToCode

Copy link
Copy Markdown

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Feb 21, 2023
@openshift-ci

openshift-ci Bot commented Feb 21, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit 2dce1f8 into openshift-knative:release-v1.7 Feb 21, 2023
@nak3 nak3 changed the title [SRVKS-999] Add probes to all deployments [release-v1.7][SRVKS-999] Add probes to all deployments Mar 3, 2023

@nak3 nak3 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skonto @ReToCode I think this change is not applied yet. We need to update the manifests with this change:

  • openshift/release/artifacts/* for SO
  • openshift/release/knative-serving-ci.yaml for CI

openshift-merge-robot pushed a commit that referenced this pull request Mar 8, 2023
* add probes to all deployments (#176)

* add missing probes (knative#13563)

* Bump manifests

---------

Co-authored-by: Stavros Kontopoulos <[email protected]>
openshift-merge-robot pushed a commit that referenced this pull request Mar 9, 2023
* add probes to all deployments (#176)

* add missing probes (knative#13563)

* Bump manifests

---------

Co-authored-by: Stavros Kontopoulos <[email protected]>
Co-authored-by: Kenjiro Nakayama <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants