Conversation
t8m
added
branch: master
paulidale
approved these changes
Mar 10, 2026
jogme
approved these changes
Mar 10, 2026
openssl-machine
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 11, 2026
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Mar 11 10:22:54 2026 (Merged from #30319)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 11, 2026
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Mar 11 10:22:54 2026 (Merged from #30319) (cherry picked from commit 7aedbb3)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 11, 2026
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Mar 11 10:22:54 2026 (Merged from #30319) (cherry picked from commit 7aedbb3)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 11, 2026
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Mar 11 10:22:54 2026 (Merged from #30319) (cherry picked from commit 7aedbb3)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 11, 2026
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Mar 11 10:22:54 2026 (Merged from #30319) (cherry picked from commit 7aedbb3)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 11, 2026
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Mar 11 10:22:54 2026 (Merged from #30319) (cherry picked from commit 7aedbb3)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 11, 2026
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Mar 11 10:22:54 2026 (Merged from #30319) (cherry picked from commit 7aedbb3)
Member
|
Merged to all the active branches. Thank you for your contribution. |
2 tasks
rickyringler
pushed a commit
to rickyringler/openssl
that referenced
this pull request
Aug 21, 2026
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Mar 11 10:22:54 2026 (Merged from openssl#30319)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description (for github.com/openssl/openssl)
title
fix OSSL_parse_url userinfo scan to respect authority boundary
body
OSSL_parse_url()usesstrchr(p, '@')to locate the userinfo delimiter, but this scans the entire remaining URL string rather than only the authority component. per RFC 3986, the authority ends at the first/,?, or#. an@in the path, query, or fragment should not be interpreted as a userinfo delimiter.this matters for callers that use the extracted host for security decisions, such as
nc_uri()incrypto/x509/v3_ncons.c(URI nameConstraints matching during certificate verification).the fix bounds the
@search to the authority component usingmemchrover the authority length (delimited bystrpbrk(p, "/?#")).example:
https://victim.com/[email protected]attacker.com(wrong,@is in the path)victim.com(correct,@outside authority is ignored)includes regression test covering
@in path, query, and fragment positions.