Conversation
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue openssl#31040) Fixes openssl#31040
idrassi
force-pushed
the
issue-31040-delta-crl
branch
from
May 14, 2026 03:12
6b26493 to
906b4d7
Compare
openssl-machine
added
the
approval: review pending
Collaborator
|
This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago |
t8m
added
triaged: bug
t8m
approved these changes
Jun 15, 2026
t8m
added
branch: master
bob-beck
approved these changes
Jun 15, 2026
openssl-machine
added
approval: done
Collaborator
|
This pull request is ready to merge |
openssl-machine
added a commit
that referenced
this pull request
Jun 17, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue #31040) Fixes #31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from #31044)
Member
|
@idrassi Why have you used openssl-machine as the author for the commit?? Unfortunately I've noticed this only when cherry-picking so on the master branch we have this with an incorrect author. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 17, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue #31040) Fixes #31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from #31044) (cherry picked from commit 5a3723e)
Contributor
Author
|
@t8m I remember that I prepared this PR from a temporary cloud Linux VM while on the move, not from my usual setup. Clearly, the local git config was bad before pushing and I didn't notice. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 17, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue #31040) Fixes #31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from #31044) (cherry picked from commit 5a3723e)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 17, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue #31040) Fixes #31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from #31044) (cherry picked from commit 5a3723e)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 17, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue #31040) Fixes #31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from #31044) (cherry picked from commit 5a3723e) (cherry picked from commit c26731f)
Member
|
Merged to all the active branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 17, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue #31040) Fixes #31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from #31044) (cherry picked from commit 5a3723e)
n13l
pushed a commit
to n13l/openssl
that referenced
this pull request
Jul 25, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue openssl#31040) Fixes openssl#31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from openssl#31044)
bernd-edlinger
pushed a commit
to bernd-edlinger/openssl
that referenced
this pull request
Aug 20, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue openssl#31040) Fixes openssl#31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from openssl#31044) (cherry picked from commit 5a3723e)
bernd-edlinger
pushed a commit
to bernd-edlinger/openssl
that referenced
this pull request
Aug 20, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue openssl#31040) Fixes openssl#31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from openssl#31044) (cherry picked from commit 5a3723e)
bernd-edlinger
pushed a commit
to bernd-edlinger/openssl
that referenced
this pull request
Aug 20, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue openssl#31040) Fixes openssl#31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from openssl#31044) (cherry picked from commit 5a3723e)
rickyringler
pushed a commit
to rickyringler/openssl
that referenced
this pull request
Aug 21, 2026
get_crl_score() is used when selecting a complete/base CRL. Its delta CRL rejection was chained after the extended CRL and IDP reason handling, so it could be skipped when extended CRL support was disabled, or when an IDP onlySomeReasons branch was taken. As a result, a CRL with a Delta CRL Indicator could be scored as a complete/base CRL candidate. Since a delta CRL contains only changes relative to a base CRL, this could cause a previously revoked certificate to be accepted as valid when only the delta CRL is presented to the verifier. Reject CRLs with base_crl_number unconditionally in get_crl_score() before IDP reason filtering. Delta CRLs are still considered by get_delta_sk() after a complete CRL is selected and check_delta_base() confirms compatibility. Add verify recipe coverage for a delta CRL being rejected as a complete CRL, and for a delta CRL with IssuingDistributionPoint.onlySomeReasons being rejected under -extended_crl. Reported-by: jujerpig (GitHub issue openssl#31040) Fixes openssl#31040 Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Wed Jun 17 08:53:02 2026 (Merged from openssl#31044)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_crl_scorecould skip delta CRL rejection when the CRL had IDP reason flags, or when extended CRL support was disabled. This allowed a CRL with a Delta CRL Indicator to be scored as a complete/base CRL candidate.If a verifier is presented only with a delta CRL and it is incorrectly accepted as a complete CRL, revocations present in the base/complete CRL but absent from the delta CRL can be silently ignored. This could cause a previously revoked certificate to be accepted as valid.
Move the
base_crl_numbercheck before the extended CRL and IDP reason handling so delta CRLs are rejected unconditionally at this selection stage. Delta CRLs remain processed through the normal delta path after a complete CRL is selected and compatibility is checked.Add verify recipe coverage for:
IssuingDistributionPoint.onlySomeReasonsbeing rejected under-extended_crlTests run (Linux Ubuntu 24.04):
Fixes #31040
Checklist