Conversation
DDvO
added
approval: review pending
2 tasks
There was a problem hiding this comment.
Pull request overview
Backports fixes to OSSL_parse_url() to parse URL schemes according to RFC 3986 constraints (avoiding false detection of schemes inside other URL components) and tightens IPv6 literal parsing to stay within the authority component. Updates the HTTP URL parsing tests to cover fragment handling and additional edge cases.
Changes:
- Update
OSSL_parse_url()scheme detection to only accept valid scheme characters and require the"://"delimiter. - Bound the search for the closing
]of an IPv6 literal to the authority section. - Extend
test/http_test.cto validate fragment parsing (including fragments containing"://") and add an additional IP/port/path test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crypto/http/http_lib.c |
Implements stricter, RFC-aligned scheme parsing and bounds IPv6 ] scanning to the authority component. |
test/http_test.c |
Adds/adjusts URL parsing tests for fragments and additional URL forms to exercise the parsing changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DDvO
changed the title
OSSL_parse_url() scheme and host parsing backport of #27357
esyr
added
the
hold: wait for master
esyr
approved these changes
May 22, 2026
jogme
approved these changes
Jun 2, 2026
Comment on lines
+87
to
+88
| && (ossl_isalpha(*p) | ||
| || ossl_isdigit(*p) |
Contributor
There was a problem hiding this comment.
nit:
ossl_isalnum() can be used
openssl-machine
added
approval: done
Collaborator
|
This pull request is ready to merge |
DDvO
removed
the
hold: wait for master
Contributor
Author
|
Lifted the hold since #27357 is now merged to master. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2026
Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Jun 10 07:15:38 2026 (Merged from #31267)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2026
Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Jun 10 07:15:39 2026 (Merged from #31267)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2026
Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Jun 10 07:15:38 2026 (Merged from #31267) (cherry picked from commit 6e3627d)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2026
Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Jun 10 07:15:39 2026 (Merged from #31267) (cherry picked from commit 58ebe68)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2026
Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Jun 10 07:15:38 2026 (Merged from #31267) (cherry picked from commit 6e3627d)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2026
Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Wed Jun 10 07:15:39 2026 (Merged from #31267) (cherry picked from commit 58ebe68)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the
OSSL_parse_url()fixes of #27357, as requested by #27357 (comment).