uni2utf8: reject negative length like uni2asc - #31378
Closed
rootvector2 wants to merge 1 commit into
Closed
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
andrewkdinh
approved these changes
Jun 6, 2026
openssl-machine
added
the
approval: review pending
tomato42
approved these changes
Jun 9, 2026
openssl-machine
added
approval: done
jogme
added
triaged: bug
esyr
approved these changes
Jun 10, 2026
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 11, 2026
Reviewed-by: Alicja Kario <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jun 11 08:57:03 2026 (Merged from #31378)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 11, 2026
Reviewed-by: Alicja Kario <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jun 11 08:56:52 2026 (Merged from #31378)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 11, 2026
Reviewed-by: Alicja Kario <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jun 11 08:56:39 2026 (Merged from #31378)
Contributor
|
Merged to all active branches. Thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 11, 2026
Reviewed-by: Alicja Kario <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jun 11 08:57:35 2026 (Merged from #31378)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 11, 2026
Reviewed-by: Alicja Kario <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jun 11 08:57:14 2026 (Merged from #31378)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 11, 2026
Reviewed-by: Alicja Kario <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jun 11 08:57:24 2026 (Merged from #31378)
n13l
pushed a commit
to n13l/openssl
that referenced
this pull request
Jul 25, 2026
Reviewed-by: Alicja Kario <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jun 11 08:56:39 2026 (Merged from openssl#31378)
rickyringler
pushed a commit
to rickyringler/openssl
that referenced
this pull request
Aug 21, 2026
Reviewed-by: Alicja Kario <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jun 11 08:56:39 2026 (Merged from openssl#31378)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPENSSL_uni2utf8 only rejects odd lengths, but its sibling OPENSSL_uni2asc also rejects negative ones. A negative even unilen skips the conversion loop and the trailing-zero probe then reads uni[unilen - 2] and uni[unilen - 1], two bytes before the buffer. Add the same unilen < 0 guard.