Conversation
Contributor
Author
|
the issue has been triggered by UB-san in CI, details are here: |
t8m
added
branch: master
openssl-machine
added
the
approval: review pending
tom-cosgrove-arm
previously approved these changes
Jun 11, 2026
tom-cosgrove-arm
left a comment
tom-cosgrove-arm
left a comment
Contributor
There was a problem hiding this comment.
LGTM. 3 CI failures are because it doesn't cherry-pick cleanly to earlier branches
t8m
requested changes
Jun 11, 2026
Member
|
Also this needs a rebase. |
The test for client_hello and new_pending connection should be using its own dedicated SSL context. The thing is we should not be arming (and testing) those callbacks for every listener the RADIX test framework creates. This changeset moves the test from test/radix/quic_ops.c to test/radix/quic_tests.c. The test uses check_ctx_cbks RADIX script now.
…amework for QUIC.
…test framework for QUIC.
t8m
approved these changes
Jun 12, 2026
Member
|
ping @tom-cosgrove-arm |
openssl-machine
added
approval: done
github-project-automation
Bot
moved this from Waiting Review
to Waiting Merge
in Development Board
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
The test for client_hello and new_pending connection should be using its own dedicated SSL context. The thing is we should not be arming (and testing) those callbacks for every listener the RADIX test framework creates. This changeset moves the test from test/radix/quic_ops.c to test/radix/quic_tests.c. The test uses check_ctx_cbks RADIX script now. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:29:02 2026 (Merged from #31421)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
The test for client_hello and new_pending connection should be using its own dedicated SSL context. The thing is we should not be arming (and testing) those callbacks for every listener the RADIX test framework creates. This changeset moves the test from test/radix/quic_ops.c to test/radix/quic_tests.c. The test uses check_ctx_cbks RADIX script now. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:29:02 2026 (Merged from #31421) (cherry picked from commit 461b688)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
The test for client_hello and new_pending connection should be using its own dedicated SSL context. The thing is we should not be arming (and testing) those callbacks for every listener the RADIX test framework creates. This changeset moves the test from test/radix/quic_ops.c to test/radix/quic_tests.c. The test uses check_ctx_cbks RADIX script now. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:29:02 2026 (Merged from #31421) (cherry picked from commit 461b688)
Member
|
Merged to the master, 4.0, 3.6 and 3.5 branches. Thank you. |
github-project-automation
Bot
moved this from Waiting Merge
to Done
in Development Board
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
The test for client_hello and new_pending connection should be using its own dedicated SSL context. The thing is we should not be arming (and testing) those callbacks for every listener the RADIX test framework creates. This changeset moves the test from test/radix/quic_ops.c to test/radix/quic_tests.c. The test uses check_ctx_cbks RADIX script now. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:29:02 2026 (Merged from #31421) (cherry picked from commit 461b688)
pr000000f
added a commit
to pr000000f/tongsuo-dev
that referenced
this pull request
Jul 22, 2026
OpenSSL original commit message From 11fb223813931724096c1b3f704c290b5231ef31 Mon Sep 17 00:00:00 2001 From: Alexandr Nedvedicky <[email protected]> Date: Tue, 9 Jun 2026 10:58:52 +0200 Subject: [PATCH] Fix use-after-free issue in radix test framework for QUIC. The test for client_hello and new_pending connection should be using its own dedicated SSL context. The thing is we should not be arming (and testing) those callbacks for every listener the RADIX test framework creates. This changeset moves the test from test/radix/quic_ops.c to test/radix/quic_tests.c. The test uses check_ctx_cbks RADIX script now. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:29:02 2026 (Merged from openssl/openssl#31421) (cherry picked from commit 461b6886285afe174a2a7385541a1ac98c08e35f)
n13l
pushed a commit
to n13l/openssl
that referenced
this pull request
Jul 25, 2026
The test for client_hello and new_pending connection should be using its own dedicated SSL context. The thing is we should not be arming (and testing) those callbacks for every listener the RADIX test framework creates. This changeset moves the test from test/radix/quic_ops.c to test/radix/quic_tests.c. The test uses check_ctx_cbks RADIX script now. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:29:02 2026 (Merged from openssl#31421)
rickyringler
pushed a commit
to rickyringler/openssl
that referenced
this pull request
Aug 21, 2026
The test for client_hello and new_pending connection should be using its own dedicated SSL context. The thing is we should not be arming (and testing) those callbacks for every listener the RADIX test framework creates. This changeset moves the test from test/radix/quic_ops.c to test/radix/quic_tests.c. The test uses check_ctx_cbks RADIX script now. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:29:02 2026 (Merged from openssl#31421)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hf_accept_conn() tests if SSL_accept() works for QUIC. Currently the function accepts connection, then binds the
connobject to radix framework and then proceeds to further tests. If further tests fail, then connection is freed and function returns to caller without ubbinding the conn object from radix framework. The framework then keeps dengling pointer.Checklist