Skip to content

test: Invert bad TEST() condition calls - #31457

Closed
t8m wants to merge 1 commit into
openssl:masterfrom
t8m:invert-bad-TEST
Closed

test: Invert bad TEST() condition calls#31457
t8m wants to merge 1 commit into
openssl:masterfrom
t8m:invert-bad-TEST

Conversation

@t8m

@t8m t8m commented Jun 11, 2026

Copy link
Copy Markdown
Member

False result of a TEST_xxx() call should always indicate erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

@t8m
test: Invert bad TEST() condition calls
3867e7d 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.
@t8m t8m added branch: master Applies to master branch triaged: bug The issue/pr is/fixes a bug tests: present The PR has suitable tests present branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 branch: 4.0 Applies to openssl-4.0 approval: review pending This pull request needs review by a committer labels Jun 11, 2026
@t8m t8m moved this to Waiting Review in Development Board Jun 11, 2026
@t8m
t8m requested a review from a team June 12, 2026 06:28
@openssl-machine openssl-machine added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 12, 2026
@github-project-automation github-project-automation Bot moved this from Waiting Review to Waiting Merge in Development Board Jun 12, 2026
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 13, 2026
@openssl-machine

openssl-machine commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jun 15, 2026
@t8m
test: Invert bad TEST() condition calls
7c765bb 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from #31457)
openssl-machine pushed a commit that referenced this pull request Jun 15, 2026
@t8m
test: Invert bad TEST() condition calls
1e386aa 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from #31457)

(cherry picked from commit 7c765bb)
openssl-machine pushed a commit that referenced this pull request Jun 15, 2026
@t8m
test: Invert bad TEST() condition calls
ea598f5 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from #31457)

(cherry picked from commit 7c765bb)
openssl-machine pushed a commit that referenced this pull request Jun 15, 2026
@t8m
test: Invert bad TEST() condition calls
9dd0977 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from #31457)

(cherry picked from commit 7c765bb)
openssl-machine pushed a commit that referenced this pull request Jun 15, 2026
@t8m
test: Invert bad TEST() condition calls
32f1349 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from #31457)

(cherry picked from commit 7c765bb)
openssl-machine pushed a commit that referenced this pull request Jun 15, 2026
@t8m
test: Invert bad TEST() condition calls
7e660d1 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from #31457)

(cherry picked from commit 7c765bb)
@t8m

t8m commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

Merged to all the active branches as applicable. Thank you for the reviews.

@t8m t8m closed this Jun 15, 2026
@github-project-automation github-project-automation Bot moved this from Waiting Merge to Done in Development Board Jun 15, 2026
n13l pushed a commit to n13l/openssl that referenced this pull request Jul 25, 2026
@t8m @n13l
test: Invert bad TEST() condition calls
a2d0727 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from openssl#31457)
pr000000f added a commit to pr000000f/tongsuo-dev that referenced this pull request Jul 29, 2026
@pr000000f
Invert (some) bad TEST() condition calls
abfa820 
The following changes are not applied:
1) test/asn1_string_test.c -> file does not exist
2) test/sslapitest.c -> test_tlsext_status_type_multi and test_no_shared_ffdhe_group do not exist
3) test/verify_extra_test.c -> test_vpm_input_validation does not exist

OpenSSL original commit message:

From 7c765bb6020b7c391dea8112f403e3b2109ff6dd Mon Sep 17 00:00:00 2001
From: Tomas Mraz <[email protected]>
Date: Thu, 11 Jun 2026 17:37:31 +0200
Subject: [PATCH] test: Invert bad TEST() condition calls

False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from openssl/openssl#31457)
rickyringler pushed a commit to rickyringler/openssl that referenced this pull request Aug 21, 2026
@t8m Ricky Ringler
test: Invert bad TEST() condition calls
7a0f0b8 
False result of a TEST_xxx() call should always indicate
erroneous condition.

Fix such calls. Also fix some calls which
treated TEST_xxx() result as non-boolean.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
MergeDate: Mon Jun 15 07:38:52 2026
(Merged from openssl#31457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes
@paulidale paulidale paulidale approved these changes
@jogme jogme jogme approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 branch: 4.0 Applies to openssl-4.0 tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug

Projects

Development Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@t8m @openssl-machine @levitte @paulidale @jogme