Conversation
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026.
mbroz
added
branch: master
slontis
reviewed
Jun 15, 2026
| vcvars: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat | ||
| - os: windows-2025 | ||
| vcvars: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat | ||
| vcvars: C:\Program Files\Microsoft Visual Studio\18\Enterprise\VC\Auxiliary\Build\vcvars64.bat |
Member
There was a problem hiding this comment.
Is there some way to use %VSINSTALLDIR% here?
Member
Author
There was a problem hiding this comment.
Well, there could be multiple VS versions installed (and even versions like community & enterprise)
I am not sure it is reliable. The path above is the default intallation path that should work.
Anyway, that is for @quarckster and a different patch, this one just unbreaks the build :)
quarckster
approved these changes
Jun 15, 2026
openssl-machine
added
the
approval: review pending
Member
|
LGTM |
t8m
added
severity: urgent
t8m
approved these changes
Jun 15, 2026
t8m
left a comment
t8m
left a comment
Member
There was a problem hiding this comment.
This is urgent as Windows CI is broken.
npajkovsky
approved these changes
Jun 15, 2026
openssl-machine
added
approval: done
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026. Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:23:17 2026 (Merged from #31497) (cherry picked from commit 164c156)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026. Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:23:17 2026 (Merged from #31497) (cherry picked from commit 164c156)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026. Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:23:17 2026 (Merged from #31497)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026. Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:23:17 2026 (Merged from #31497) (cherry picked from commit 164c156)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2026
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026. Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:23:17 2026 (Merged from #31497) (cherry picked from commit 164c156)
Member
|
Merged to the master, 4.0, 3.6, 3.5 and 3.4 branches. Thank you. |
2 tasks
n13l
pushed a commit
to n13l/openssl
that referenced
this pull request
Jul 25, 2026
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026. Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:23:17 2026 (Merged from openssl#31497)
rickyringler
pushed a commit
to rickyringler/openssl
that referenced
this pull request
Aug 21, 2026
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026. Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Mon Jun 15 07:23:17 2026 (Merged from openssl#31497)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Windows CI builds are failing due to migration described in actions/runner-images#14017
GitHub no longer supports Visual Studio 2022 on windows-2025 image, switch to VS 2026.
An alternative is to use windows-2022 image, but then the test matrix does no longer make sense (the goal was to test new Windows here).