Skip to content

Merge of DSA mod inverse fix to 1.0.2. - #7512

Closed
paulidale wants to merge 1 commit into
openssl:OpenSSL_1_0_2-stablefrom
paulidale:dsa-mod-inverse-102
Closed

paulidale wants to merge 1 commit into
openssl:OpenSSL_1_0_2-stablefrom
paulidale:dsa-mod-inverse-102

Conversation

@paulidale

Copy link
Copy Markdown
Contributor

Refer #7487

There is a side channel attack against the division used to calculate one of
the modulo inverses in the DSA algorithm. This change takes advantage of the
primality of the modulo and Fermat's little theorem to calculate the inverse
without leaking information.

Thanks to Samuel Weiser for finding and reporting this.
@levitte levitte added the branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL) label Oct 29, 2018
@paulidale

Copy link
Copy Markdown
Contributor Author

Merged, thanks.

@paulidale paulidale closed this Oct 29, 2018
levitte pushed a commit that referenced this pull request Oct 29, 2018
There is a side channel attack against the division used to calculate one of
the modulo inverses in the DSA algorithm. This change takes advantage of the
primality of the modulo and Fermat's little theorem to calculate the inverse
without leaking information.

Thanks to Samuel Weiser for finding and reporting this.

Reviewed-by: Richard Levitte <[email protected]>
(Merged from #7512)
@paulidale
paulidale deleted the dsa-mod-inverse-102 branch October 29, 2018 21:51
rvagg added a commit to rvagg/io.js that referenced this pull request Nov 14, 2018
Low severity timing vulnerability in the DSA signature algorithm

Publicly disclosed but unreleased, pending OpenSSL 1.0.2q, not deemed
severe enough to be assigned a CVE #.

Ref: openssl/openssl#7487
Ref: openssl/openssl#7512
Ref: nodejs#23965
Upstream: openssl/openssl@415c3356
Upstream: openssl/openssl@ebf65dbe

Original commit message:

    DSA mod inverse fix

    There is a side channel attack against the division used to calculate one of
    the modulo inverses in the DSA algorithm.  This change takes advantage of the
    primality of the modulo and Fermat's little theorem to calculate the inverse
    without leaking information.

    Thanks to Samuel Weiser for finding and reporting this.

    Reviewed-by: Matthias St. Pierre <[email protected]>
    Reviewed-by: Bernd Edlinger <[email protected]>
    (Merged from openssl/openssl#7487)

Original backport commit message:

    Reviewed-by: Richard Levitte <[email protected]>
    (Merged from openssl/openssl#7512)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: 1.0.2 Applies to OpenSSL_1_0_2-stable branch (EOL)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants