Repository navigation
Use explode() instead of split() - #25488
Merged
Merged
Conversation
|
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @lenz1111, @Xenopathic and @icewind1991 to be potential reviewers |
| */ | ||
| private static function parseHttpRangeHeader($rangeHeaderPos, $fileSize) { | ||
| $rArray=split(',', $rangeHeaderPos); | ||
| $rArray=explode(',', $rangeHeaderPos); |
Contributor
There was a problem hiding this comment.
We should probably write an unit test for this to detect it in the future 😇
Contributor
Author
There was a problem hiding this comment.
this code will die in 9.2 - in addition this whole file is almost untestable
Contributor
|
👍 |
ghost
mentioned this pull request
DeepDiver1975
added a commit
that referenced
this pull request
Jul 17, 2016
DeepDiver1975
added a commit
that referenced
this pull request
Jul 17, 2016
DeepDiver1975
added a commit
that referenced
this pull request
Jul 20, 2016
LukasReschke
added a commit
to nextcloud/server
that referenced
this pull request
Jul 20, 2016
LukasReschke
added a commit
to nextcloud/server
that referenced
this pull request
Jul 20, 2016
This was referenced Jul 20, 2016
DeepDiver1975
added a commit
that referenced
this pull request
Jul 24, 2016
ghost
mentioned this pull request
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #25483