Skip to content

Unset user PHOTO before setting new one in OCA\DAV\CardDAV\Converter::updateCard - #26243

Merged
DeepDiver1975 merged 1 commit into
owncloud:masterfrom
shtrom:issue26242/update-vcard-photo
Sep 29, 2016
Merged

DeepDiver1975 merged 1 commit into
owncloud:masterfrom
shtrom:issue26242/update-vcard-photo

Conversation

@shtrom

@shtrom shtrom commented Sep 28, 2016

Copy link
Copy Markdown
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Olivier Mehani [email protected]
#26242

@CLAassistant

CLAassistant commented Sep 28, 2016 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mention-bot

Copy link
Copy Markdown

@shtrom, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975 to be a potential reviewer

@DeepDiver1975

Copy link
Copy Markdown
Contributor

Makes absolute sense. Thx.
👍

@shtrom

shtrom commented Sep 29, 2016

Copy link
Copy Markdown
Contributor Author

CLA signed (though that's yet another license agreement that didn't get read...)

@DeepDiver1975

Copy link
Copy Markdown
Contributor

jenkins is green -> merge

@DeepDiver1975
DeepDiver1975 merged commit 87d67a0 into owncloud:master Sep 29, 2016
DeepDiver1975 pushed a commit that referenced this pull request Sep 29, 2016
DeepDiver1975 pushed a commit that referenced this pull request Sep 29, 2016
DeepDiver1975 added a commit that referenced this pull request Sep 30, 2016
DeepDiver1975 added a commit that referenced this pull request Sep 30, 2016
@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants