Skip to content

Display modal in front of nav #268

Closed

Description

@mef

Currently, the modal component has a z-index of 12, whereas the z-index of the nav component is 100.

This makes the modal to be displayed below navbar. This is especially problematic on devices with smaller screen, where the modal panel's content might be partly covered by the nav.

Should the modal's z-index be increased to 101?

Activity

  1. koester commented on Mar 14, 2022

    @koester
    Contributor

    Thanks for opening an issue and yes, your proposed solution is right.

    I would suggest to increase the z-index of the modal even higher than 101, probably around 200, just so we have some room for other components later on. The Modal should have the highest z-index of any component, since the use case is to overlap the whole page.

    Feel free to open a PR with your proposed change :)

  2. added a commit that references this issue on Mar 22, 2022
    8e61aa1
  3. added 2 commits that reference this issue on Nov 24, 2022
    95dfa83
    7e02a85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions