Repository navigation
validateEmailConfiguration should be called when sending reset password email #1649
Description
- You've met the prerequisites.
- You're running the latest version of Parse Server.
- You've searched through existing issues. Chances are that your issue has been reported or resolved before.
Environment Setup
Parse Server 2.2.7 on Heroku
Steps to reproduce
- Configure an Email Adapter in index.js
- Don't configure app name and/or public server URL
- Request a reset password email via
requestPasswordReset
Result
Users will receive an email with title "Password reset for undefined", and body:
"You requested to reset your password for undefined. Click here to reset it: undefined/apps/....."
Expected Result
validateEmailConfiguration or some variation of it should be called before sending reset password emails, to make sure that both app name and public server url were set correctly.
Activity
drew-gross commentedon Apr 26, 2016
Yep that definitely should be called. Not sure when it stopped being called.
Regression test parse-community#1649
drew-gross commentedon Apr 26, 2016
Actually this seems to be a different issue. I made a regression test in #1650 and it passes.
natanrolnik commentedon Apr 27, 2016
The regression test you wrote doesn't really test what I mentioned here. I'll comment on the PR.
I think it's still a bug.
damtsnkff commentedon Apr 30, 2016
@natanrolnik Did you solve it ? I'm facing the exact same problem. I tried with
parse-server:~2.2.7and~2.2.2damtsnkff commentedon Apr 30, 2016
@natanrolnik @drew-gross Ok that was a stupid mistake. I forgot the
publicServerURL... and I was checking the wrongindex.jswhen debugging. Fixed for me.Regression test parse-community#1649
Regression test parse-community#1649
Regression test parse-community#1649
Merge remote-tracking branch 'upstream/master'