Repository navigation
Master tests failing. Need better notification #5500
Description
tests failing since https://travis-ci.org/parse-community/parse-server/builds/515639414
- Investigate and fix.
- Check to understand how to get 'higher priority' notification when repos in parse-community are failing beyond some certain threshold.
Activity
TomWFox commentedon Apr 13, 2019
Perhaps Travis Buddy could help with number 2?
It comments on PRs if the tests are failing and shows the relevant part of the log + it looks super easy to setup - but I'm not sure whether you can set it so it only comments if over a certain number of tests fail.
dplewis commentedon Apr 13, 2019
@vitaly-t I remember you posted about mongo url strings #986 (comment)
You want to submit a PR?
vitaly-t commentedon Apr 13, 2019
@dplewis I have no practical knowledge about parse-server, i.e. I only helped with the database layer for PostgreSQL, but I never used the library myself.
Given just how completely generic connection-string is, perhaps it is better that someone well familiar with parser-server does it?
acinader commentedon Apr 13, 2019
@stage88 and I are on the tests. It has nothing to do with the mongo adapter, it’s how jasmine handles spies has changed subtly in a way that broke some tests.
This case will be solved shortly. I’m more concerned about notifications that prevent this from going unnoticed. I’ll have better internet soon.
dplewis commentedon Apr 13, 2019
@acinader The issue is how unhandled promises are no longer warnings and uncaughtException are handled differently.
For the mongo tests. in
connect()For index.spec.js add a catch to deleteAllClasses
dplewis commentedon Apr 13, 2019
I edited my last comment. We shouldn't run into this issue anymore. As unhandled promises will make tests fail.
Cause: jasmine/jasmine#1521
acinader commentedon Apr 14, 2019
@dplewis I think that's a legitimate add to the mongo adapter connect method, but it does not solve the failing test. I'm still trying to work out what's going on.
acinader commentedon Apr 14, 2019
actually @dplewis I don't see where your change could be introduced.
the
MongoClient.connectpromise will not resolve if there is no client.still trying to work it out :(
acinader commentedon Apr 14, 2019
for those of you playing along at home, I can confirm that the unhandled rejection is occurring during the initialization of ParseServer and not during the rest post to create a new object.
davimacedo commentedon May 14, 2019
@acinader I think we can close this one, right?
davimacedo commentedon May 14, 2019
Or do we still need to lead with number 2?
acinader commentedon May 14, 2019
yes, I think we can close. the issue with #2 is just for me to figure out why i stopped getting notifications on failure.