fix: Unauthenticated deletion of class schemas removes class-level permissions on MongoDB (GHSA-qmg9-m772-5rm7) by mtrezza · Pull Request #10768 · parse-community/parse-server

mtrezza · 2026-10-08T21:52:05Z

Issue

Unauthenticated deletion of class schemas removes class-level permissions on MongoDB (GHSA-qmg9-m772-5rm7)

Tasks

Add tests
Add changes to documentation (guides, repository pages, code comments)
Add security check
Add new Parse Error codes to Parse JS SDK

parse-github-assistant · 2026-10-08T21:52:08Z

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
Group code into logical blocks. Add a short comment before each block to explain its purpose.
We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

coderabbitai · 2026-10-08T21:52:15Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: 24712456-3052-4e23-9037-031bceb4d370

📥 Commits

Reviewing files that changed from the base of the PR and between 5d0d6cd and 41ea949.

📒 Files selected for processing (2)

spec/vulnerabilities.spec.js
src/SharedRest.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

Shared REST now rejects requests to invalid class names from non-master, non-maintenance callers. Vulnerability tests cover _SCHEMA access attempts under both client class creation settings and check that the Secret schema remains intact.

Changes

Class access protection

Layer / File(s)	Summary
Invalid class checks and vulnerability coverage `src/SharedRest.js`, `spec/vulnerabilities.spec.js`	Shared REST rejects requests to invalid class names for non-master, non-maintenance callers. Tests cover denied `_SCHEMA` operations, including requests with a user session, and verify the `Secret` schema and its `find` CLP remain intact.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 41ea9

The protected schema operations are denied on the tested routes. No identified issue prevents merging after normal checks.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Description check	❌ Error	No pull request description was provided. The required Issue, Approach, and Tasks sections are missing, along with the details needed to explain the security fix and testing.	Add a pull request description that follows the repository template. Describe the issue, explain the approach, and complete the applicable Tasks items, including the added tests and security check.

✅ Passed checks (6 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses the required `fix:` prefix and identifies the security advisory addressed by the changes. The first character after the prefix is capitalized.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Security Check	✅ Passed	No security vulnerability is introduced. The changed `SharedRest.enforceRoleSecurity` now rejects non-master, non-maintenance access when `SchemaController.classNameIsValid` rejects the collection nam…
Engage In Review Feedback	✅ Passed	The current review produced zero actionable findings, and no CodeRabbit review threads were returned. There is no review feedback that requires engagement under this check.

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

mtrezza · 2026-10-08T21:53:54Z

@coderabbitai review

coderabbitai · 2026-10-08T21:54:02Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Pre-merge checks failed. Please resolve the failing checks before merging.

codecov · 2026-10-08T21:59:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.68%. Comparing base (9133478) to head (41ea949).
⚠️ Report is 1 commits behind head on release-8.x.x.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.x.x   #10768      +/-   ##
=================================================
- Coverage          92.70%   92.68%   -0.03%     
=================================================
  Files                192      192              
  Lines              16336    16339       +3     
  Branches             238      238              
=================================================
- Hits               15144    15143       -1     
- Misses              1171     1175       +4     
  Partials              21       21

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

## [8.6.101](8.6.100...8.6.101) (2026-10-08) ### Bug Fixes * Unauthenticated deletion of class schemas removes class-level permissions on MongoDB ([GHSA-qmg9-m772-5rm7](GHSA-qmg9-m772-5rm7)) ([#10768](#10768)) ([2f3e236](2f3e236))

parseplatformorg · 2026-10-08T22:58:46Z

🎉 This change has been released in version 8.6.101

fix: GHSA-qmg9-m772-5rm7

41ea949

coderabbitai Bot requested changes Oct 8, 2026

View reviewed changes

coderabbitai Bot approved these changes Oct 8, 2026

View reviewed changes

mtrezza changed the title ~~fix: GHSA-qmg9-m772-5rm7~~ fix: Unauthenticated deletion of class schemas removes class-level permissions on MongoDB (GHSA-qmg9-m772-5rm7) Oct 8, 2026

mtrezza merged commit 2f3e236 into parse-community:release-8.x.x Oct 8, 2026
64 of 70 checks passed

mtrezza deleted the fix/GHSA-qmg9-m772-5rm7-8 branch October 8, 2026 22:58

parseplatformorg added the state:released-8.x.x Released as LTS version label Oct 8, 2026

Navigation Menu

Repository navigation

fix: Unauthenticated deletion of class schemas removes class-level permissions on MongoDB (GHSA-qmg9-m772-5rm7) - #10768

fix: Unauthenticated deletion of class schemas removes class-level permissions on MongoDB (GHSA-qmg9-m772-5rm7)#10768
mtrezza merged 1 commit into
parse-community:release-8.x.xfrom
mtrezza:fix/GHSA-qmg9-m772-5rm7-8

mtrezza commented Oct 8, 2026 •

edited

Loading

Uh oh!

parse-github-assistant Bot commented Oct 8, 2026

Uh oh!

coderabbitai Bot commented Oct 8, 2026 •

edited

Loading

Walkthrough

Changes

Pre-merge checks failed

Uh oh!

mtrezza commented Oct 8, 2026

Uh oh!

coderabbitai Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

codecov Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

parseplatformorg commented Oct 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mtrezza commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Tasks

Uh oh!

parse-github-assistant Bot commented Oct 8, 2026

Uh oh!

coderabbitai Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Pre-merge checks failed

❌ Failed checks (1 error)

Uh oh!

mtrezza commented Oct 8, 2026

Uh oh!

coderabbitai Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

parseplatformorg commented Oct 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mtrezza commented Oct 8, 2026 •

edited

Loading

coderabbitai Bot commented Oct 8, 2026 •

edited

Loading

coderabbitai Bot commented Oct 8, 2026 •

edited

Loading

codecov Bot commented Oct 8, 2026 •

edited

Loading