Adds generic support additional OAuth providers - #247

@flovilmart updated the pull request.

Twitter is a bit trickier because it requires header signature with OAuth1.

@flovilmart updated the pull request.

@nlutsenko there seems to be a problem with the test suite as it randomly fails after downloading a certain version of mongo-db... Not sure what's happening here.

@flovilmart updated the pull request.

Twitter is giving me some pain... Stupid OAuth 1.0

@flovilmart updated the pull request.

This is beautiful. 👍

@gfosco, I'll refactor to pass just authData and options to both validation calls, it will be cleaner and more extensible

@flovilmart updated the pull request.

@gfosco refactor is done, adds ability also to pass custom modules as validators :) that will help with extensibility. And obviously is covered by tests.

+1

• YES! Please merge already.

+1

hi @flovilmart
I have a problem about twitter aouth.

I using like that.

curl -X POST
-H "X-Parse-Application-Id: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
-H "X-Parse-REST-API-Key: yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy"
-H "X-Parse-Revocable-Session: 1"
-H "Content-Type: application/json"
-d '{
"authData": {
"twitter": {
"id": "12345678",
"screen_name": "ParseIt",
"consumer_key": "SaMpLeId3X7eLjjLgWEw",
"consumer_secret": "SaMpLew55QbMR0vTdtOACfPXa5UdO2THX1JrxZ9s3c",
"auth_token": "12345678-SaMpLeTuo3m2avZxh5cjJmIrAfx4ZYyamdofM7IjU",
"auth_token_secret": "SaMpLeEb13SpRzQ4DAIzutEkCE2LBIm2ZQDsP3WUU"
}
}
}'
http://localhost:1337/users

response come like that

{
"code": 200
"error": "bad or missing username"
}

What is my wrong ?

Thank you

@kkaradag2 I didn't test with the REST API, I'll add the according Unit tests to make sure that work. please stay tuned!

@flovilmart updated the pull request.

@flovilmart I finaly run twitter register. I notice that, git clone come someting is wrong or miss. I read carefully your comments and changes so I created a running version on m local.
Now I can work with parse-server but I want to say http://localhost:1337/users registration for twitter accounts need for check user already has. Because I can create one than more same user.
Thank you for your response.

@kkaradag2 does your bug reproduces with Facebook as well? this is maybe a more generalized bug

I didn't try to create a user with Facebok. May be yes this is a general problem with oauth. Because normal registration (username and password one) say
{
"code": 202
"error": "Account already exists for this username"
}

oauth registration needs same control.

Thank you

Hey total beginner here. How might one utilize this via the iOS/Android Client SDK's?
Does this give the ability for my users to continue using Twitter login as seamlessly as Facebook post-migration?
If not, what would have to be done to implement these advantages in the Parse Client SDK's?

@FridayDevGroup there is a gist there: https://gist.github.com/flovilmart/68a6c538496953408bb1 with the example for the twitter login

@flovilmart updated the pull request.

@flovilmart updated the pull request.

@flovilmart Thank you very very much. That example is gorgeous. So for the Twitter users currently registered to my app, this will query and return the user account created pre-migration? Apologies if the answer to that is ubiquitous.

@FridayDevGroup it definitely should. The original SDK also pass the consumer_key and consumer_secret alongside the authData, you can pass them also but that's optional as the token verification is made based on the oauth configuration as described in the readme.

@flovilmart Awesome, thank you. I'm going to get going with all of this soon. About the readme, I tried to take a look at the example links you dropped in there earlier and they're all returning 404. I think they may have gotten moved around when the Parse-Server folder restructuring pr got merged, but I couldn't track down the new locations.

@FridayDevGroup it's because it's not merged yet :) On another point, you should not need those links :)

@flovilmart Yeah.. I had a feeling it was my own misunderstanding haha. Thanks again for the guidance.

no problemo!

Hello @flovilmart

I'm not sure if this issue is related with oAuth specifically or the parse save function but here's what I'm facing.

I'm trying to link a Twitter account to an existing parse account using Cloud Code and I'm getting a code: 206, message: 'cannot modify user error.

It seems a request.user.save() function when run within Cloud Code does not pass the sessionToken in this case.

Here's my original request:

POST /parse/functions/LinkTwitterAccount { host: 'af3098d9.ngrok.io',
  'content-type': 'application/json',
  'content-length': '349',
  'x-parse-session-token': 'r:<snipped>',
  accept: '*/*',
  'user-agent': 'Pinglar/0.2 (iPhone; iOS 9.2.1; Scale/2.00)',
  'x-parse-application-id': '<snipped>',
  'accept-language': 'en-IN;q=1',
  'accept-encoding': 'gzip, deflate',
  'x-forwarded-proto': 'https',
  'x-forwarded-for': '120.88.191.119' } {
  "twitterID": <snipped>,
  "socialAuthData": {
    "twitter": {
      "auth_token": "<snipped>",
      "id": "<snipped>",
      "screen_name": "<snipped>",
      "consumer_key": "<snipped>",
      "consumer_secret": "<snipped>",
      "auth_token_secret": "<snipped>"
    }
  }
}

Here's the request made on request.user.save() in cloud code

PUT /parse/classes/_User/NSME8tT0tf { 'user-agent': 'node-XMLHttpRequest, Parse/js1.7.0 (NodeJS 4.2.6)',
  accept: '*/*',
  'content-type': 'text/plain',
  host: 'localhost:1337',
  'content-length': '500',
  connection: 'close' } {
  "authData": {
    "twitter": {
      "auth_token": "<snipped>",
      "id": "<snipped>",
      "screen_name": "<snipped>",
      "consumer_key": "<snipped>",
      "consumer_secret": "<snipped>",
      "auth_token_secret": "<snipped>"
    }
  }
}

Here's my cloud code

< Code to cleanup a few here is omitted >

request.user.set("authData", socialAuthData);
// Save user
request.user.save({useMasterKey:true}).then(function(userObject) {
  response.success(userObject);
  }, function(error) {
    console.log("Unable to save current user" + error.message);
    response.error("There was a problem creating your account, please try again");
});

Specifying a master key too doesn't help and I still get the 206 error code which is for missing sessionToken.

I don't think you can explicitly set authData like that. What does the JS SDK suggest for linking?

Just tried it again with useMasterKey:true and it worked. I think any changes made to request.user within a cloud code function will still need to use the masterkey. I think one shouldn't be required to use masterKey to modify request.user objects, what do you think? Should I open this as a separate issue?

Anyhow this issue thankfully isn't related to this pull request, hope this gets merged asap.

Can you try on the master branch with a Facebook auth data? See if it's a regression or not.

Looks awesome! Thanks a lot @flovilmart

🎉 !

Whee!! We finally have it!

Ahah! I'm drinking a beer to cheer on that! 🍻 for everyone at Parse HQ!

What about adding documentation for this?

Lots going on here but not enough documentation, so is the new syntax for index.js as such:

auth: { facebook: { appIds: ["XXXXXXXXXX"] } }, oauth: { twitter: { consumer_key: "XXXXXXXXXX", consumer_secret: "XXXXXXXXXX" },

oauth is deprecated in favor of auth.

Does that mean Parse Server (2.3.0+) doesn't support Twitter login? I thought this was covered in this PR

It just means that parse-server prefers the auth option instead of oauth. It doesn't change what's supported, just the option name.