Repository navigation
Adds liniting into the workflow - #3082
Merged
Merged
Conversation
|
@flovilmart updated the pull request - view changes |
|
@flovilmart updated the pull request - view changes |
|
@flovilmart updated the pull request - view changes |
|
@flovilmart updated the pull request - view changes |
steven-supersolid
approved these changes
Nov 24, 2016
steven-supersolid
left a comment
steven-supersolid
left a comment
Contributor
There was a problem hiding this comment.
LGTM and like that we are keeping the rules close to the recommended
| "ecmaVersion": 6, | ||
| "sourceType": "module" | ||
| }, | ||
| "rules": { |
Contributor
There was a problem hiding this comment.
nits:
no-extra-boolean-castdoesn't seem to be required- Would be clearer to use string value
"off"forno-console no-emptywould be closer to eslint:recommended with value["error", { "allowEmptyCatch": true }], otherwise would use"off"
Contributor
Author
There was a problem hiding this comment.
I'll add the nits and rebase :)
|
@flovilmart updated the pull request - view changes |
|
@flovilmart updated the pull request - view changes |
|
@flovilmart updated the pull request - view changes |
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 3, 2016
* initial linting of src * fix indent to 2 spaces * Removes unnecessary rules * ignore spec folder for now * Spec linting * Fix spec indent * nits * nits * no no-empty rule
Jcarlosjunior
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 13, 2016
* initial linting of src * fix indent to 2 spaces * Removes unnecessary rules * ignore spec folder for now * Spec linting * Fix spec indent * nits * nits * no no-empty rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds linting to to workflow, reporting build errors when lint is no OK.
Rules are the recommended rules.
This should work out of the box in your favorite editor.