Skip to content

Ensure users with undefined ACL are treated as readable - #4795

Merged
flovilmart merged 3 commits into
masterfrom
fix/issue-4790-login-legacy-user
May 30, 2018
Merged

flovilmart merged 3 commits into
masterfrom
fix/issue-4790-login-legacy-user

Conversation

@flovilmart

@flovilmart flovilmart commented May 30, 2018 •

Copy link
Copy Markdown
Contributor

@flovilmart flovilmart changed the title Ensure users with ACL set to null are treated as readable Ensure users with undefined ACL are treated as readable May 30, 2018
@flovilmart
flovilmart requested a review from acinader May 30, 2018 13:43
@codecov

codecov Bot commented May 30, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #4795 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4795      +/-   ##
==========================================
- Coverage   92.71%   92.68%   -0.03%     
==========================================
  Files         119      119              
  Lines        8686     8686              
==========================================
- Hits         8053     8051       -2     
- Misses        633      635       +2
Impacted Files Coverage Δ
src/Routers/UsersRouter.js 93.12% <100%> (ø) ⬆️
src/Adapters/Auth/linkedin.js 81.81% <0%> (-4.55%) ⬇️
src/Adapters/Auth/facebook.js 80% <0%> (-4%) ⬇️
src/Adapters/Auth/facebookaccountkit.js 72.72% <0%> (-3.04%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.24% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4422c4...832c65b. Read the comment docs.

@flovilmart
flovilmart force-pushed the fix/issue-4790-login-legacy-user branch 3 times, most recently from 66ab1a9 to e33a746 Compare May 30, 2018 14:04
@flovilmart
flovilmart force-pushed the fix/issue-4790-login-legacy-user branch from e33a746 to 1bd8056 Compare May 30, 2018 14:06
@flovilmart
flovilmart merged commit 9bff44b into master May 30, 2018
@flovilmart
flovilmart deleted the fix/issue-4790-login-legacy-user branch May 30, 2018 16:55
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
…ity#4795)

* Adds test to reproduce issue parse-community#4790

* Attempt to allow failure on node STABLE

* Use new format for apt packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants