Repository navigation
Fix build with mtl-2.3 - #10
Merged
Merged
Conversation
mtl-2.3 no longer reexports `Control.Monad`
Collaborator
|
Thanks for the PR! Because this project uses a stack.yaml and the LTS is set to 20.17, the MTL package version is already pinned to 2.2.2 (at least if you are building with stack, there's no cabal version bounds). If we want to release a new version for support in a later LTS, we should bump the stack snapshot first and fix any errors that appear through that. It looks like there isn't any active snapshot that I see with MTL 2.3...we might need to wait for that. Alternatively we could use CPP here to deal with the breaking changes |
Collaborator
|
Oh, just realized since these are re-export of same function it should be ok. Let me just run this through CI and might be able to merge it |
Collaborator
|
All good, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mtl-2.3 no longer reexports
Control.Monad