Skip to content

Add proper replay protection #68

Description

@michielbdejong

I copied the replay detector from Solid-Nextcloud but this server does not have a database server so I didn't find a good way to store/query previously used JTIs.

I disabled it for now to see if I can get the tests to pass, but at the very least we should implement this with storing the data in some text file or something.

Activity

  1. added a commit that references this issue on Sep 1, 2023
  2. Potherca commented on Jul 8, 2024

    @Potherca
    Member

    The current storage engine for the PHP Solid Server is "on disk", using FlySystem so "disk" does not have to be a local disk but could also be an AWS S3 bucket, or a Database, etc.

    I think ypur first effort (on the test-suite-fixes-2023, adding src/DpopFactoryTrait.php and src/JtiReplayDetector.php, is a good start. (Although we might want to place those files in another location).

  3. added this to the v0.8.0 milestone on Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions