Repository navigation
Fix deleting temp file when spooling large stream to disk in StreamWrapper - #4190
Merged
sehrope merged 1 commit intoJun 16, 2026
Merged
Conversation
…eption The cleanup catch in StreamWrapper(InputStream) handled RuntimeException, Error, and PSQLException, but the most likely failure inside that block is an IOException from copyStream or write. An IOException bypassed the cleanup, propagated to the outer catch, and was wrapped in a PSQLException, leaving the temp file on disk with no cleaner registered to delete it. Every I/O failure while spooling a large stream to disk leaked a file in the temp directory. IOException is now included in the cleanup multi catch so the temp file is deleted before the exception is wrapped and rethrown.
vlsi
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup block catches the rest of exception types but is noticeably missing handling for
IOException. So if there's an error writing to the file, the temp file will stay on disk. Even though it's a checked exception, this wasn't noticed because the outer try-catch handlingIOException.Fix is to just add that additional exception type in the catch. It'll get rethrown immediately after attempting to remove the temp file so there's no change in error handling behavior either.