Repository navigation
fix: reject null URL in Driver.acceptsURL with a clear NullPointerException - #4205
Merged
Merged
Conversation
…eption A misconfigured container can pass a null URL to the driver. In acceptsURL this previously surfaced as an opaque NullPointerException from URL parsing that looks like a driver bug. Fail fast with Objects.requireNonNull instead, matching how connect(null) already rejects a null URL. Co-authored-by: Yev <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]>
vlsi
force-pushed
the
fix/acceptsurl-null-check
branch
from
June 22, 2026 14:28
de00b9f to
f8d8c52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A misconfigured J2EE container (e.g. Tomcat) can hand the driver a null URL.
Driver.connect(null, ...)already rejects this with a clearSQLException("url is null"), butDriver.acceptsURL(null)still falls through to URL parsing and throws an opaqueNullPointerExceptionthat looks like a driver bug.This revives the intent of #1317. The original blocker there —
Objects.requireNonNullnot compiling under Java 1.6 — no longer applies: the driver requires Java 8+ and already usesObjects.requireNonNullthroughout.What
acceptsURLnow callsObjects.requireNonNull(url, "url")before parsing, so a null URL fails fast with a clear message instead of an opaque NPE. This matches howconnecttreats a null URL as a caller error.DriverTest.acceptsUrlRejectsNullcovering the null case.How to verify
Co-authored-by: @yevster, whose original patch in #1317 proposed this check.