Repository navigation
Strip credentials in case of 400 on /v3/auth/tokens #335
Description
Seriously, such an exception (the one on /v3/auth/tokens should be caught to avoid displaying credentials).
In -production, they would be logged which is not much better. Such a failure should be cleaned before being thrown.
Stack
at vendor/php-opencloud/openstack/src/Common/Error/Builder.php:128
at OpenStack\Common\Error\Builder->httpError()
(vendor/php-opencloud/openstack/src/Common/Transport/Middleware.php:27)
at OpenStack\Common\Transport\Middleware::OpenStack\Common\Transport\{closure}()
(vendor/guzzlehttp/promises/src/FulfilledPromise.php:41)
at GuzzleHttp\Promise\FulfilledPromise::GuzzleHttp\Promise\{closure}()
(vendor/guzzlehttp/promises/src/TaskQueue.php:48)
at GuzzleHttp\Promise\TaskQueue->run()
(vendor/guzzlehttp/promises/src/Promise.php:248)
at GuzzleHttp\Promise\Promise->invokeWaitFn()
(vendor/guzzlehttp/promises/src/Promise.php:224)
at GuzzleHttp\Promise\Promise->waitIfPending()
(vendor/guzzlehttp/promises/src/Promise.php:62)
at GuzzleHttp\Promise\Promise->wait()
(vendor/guzzlehttp/guzzle/src/Client.php:187)
at GuzzleHttp\Client->request()
(vendor/php-opencloud/openstack/src/Common/Api/OperatorTrait.php:119)
at OpenStack\Common\Resource\OperatorResource->sendRequest()
(vendor/php-opencloud/openstack/src/Common/Api/OperatorTrait.php:127)
at OpenStack\Common\Resource\OperatorResource->execute()
(vendor/php-opencloud/openstack/src/Identity/v3/Models/Token.php:117)
at OpenStack\Identity\v3\Models\Token->create()
(vendor/php-opencloud/openstack/src/Identity/v3/Service.php:74)
at OpenStack\Identity\v3\Service->generateToken()
Activity
[-]Strip OS credentials in case of 400 on /v3/auth/tokens[/-][+]Strip credentials in case of 400 on /v3/auth/tokens[/+]jeroenlammerts commentedon Mar 15, 2023
#259 disabling the http_errors is not working, looks like there is a custom middelware which throws the error above with credentials.
openstack/src/Common/Error/Builder.php
Line 106 in 1296815
add errorVerbosity (#400)
Upstream sync (#12)
Feature/ck 2099 merge upstream (#13)