Repository navigation
[java] UnitTestShouldIncludeAssert: False positive with SoftAssertionsExtension on parent/grandparent classes - #6432
Merged
adangel merged 5 commits intoFeb 22, 2026
Conversation
…sExtension on parent/grandparent classes
kaliy
changed the title
Contributor
|
Compared to main: (comment created at 2026-02-22 17:27:41+00:00 for b1876d7) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR fixes a false postive in the
UnitTestShouldIncludeAssertrule when using AssertJ'sSoftAssertionsExtensionwith nested test classes.Previously, the rule only recgnized
@ExtendWith(SoftAssertionsExtension.class)when it was declared on the same class as the test method. But extension applies to nested classes too. PMD was reporting missing assertions when the extension was declared on a parent or grandparent class.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)