Repository navigation
[apex] Remove class name suffix "Test" as indicator of test classes - #6563
Merged
Merged
Conversation
The only indicator of an Apex test class should be the isTest() property
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
dschach
marked this pull request as ready for review
April 1, 2026 17:35
Contributor
|
Compared to main: (comment created at 2026-04-07 17:32:40+00:00 for 415f5cf) |
Contributor
Author
|
@adangel Updated Apex check for test class to look only at IsTest annotation in the helper class. Please see the referenced issues for context. I had to update another test because it relied on the class name filter; I updated it to use the annotation, as that is an Apex requirement anyway. |
adangel
reviewed
Apr 7, 2026
adangel
changed the title
adangel
added a commit
that referenced
this pull request
Apr 7, 2026
adangel
added a commit
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only indicator of an Apex test class should be the isTest() property
Describe the PR
The existing code was indicating that any class with
@IsTestannotation OR ending inTestwas a test class.The only way to identify an Apex test class should be the annotation check.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)