Skip to content

[dist] chore: Improve error message for missing JAVA_HOME in AntIT.java - #6577

Merged
adangel merged 1 commit into
pmd:mainfrom
UncleOwen:antit-fixes
Apr 7, 2026
Merged

adangel merged 1 commit into
pmd:mainfrom
UncleOwen:antit-fixes

Conversation

@UncleOwen

@UncleOwen UncleOwen commented Apr 5, 2026 •

Copy link
Copy Markdown
Member

Describe the PR

  • Make the error message more obvious, when JAVA_HOME is not set. (I've had this happen to me too many times...)
  • Use lambda to create the Thread-Runnable.
  • Don't call process.getInputStream() twice (Or is there a particular reason this is done this way that I'm missing?)

Related issues

none

Ready?

  • [n/a] Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • [n/a] Added (in-code) documentation (if needed)

* Make the error message more obvious, when JAVA_HOME is not set.
  (I've had this happen to me too many times...)
* Use lambda to create the Thread-Runnable.
* Don't call process.getInputStream() twice
  (Or is there a particular reason this is done this way that I'm missing?)
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@UncleOwen UncleOwen changed the title Various small changes to AntIT.java: [dist] Various small changes to AntIT.java: Apr 5, 2026
@pmd-actions-helper

Copy link
Copy Markdown
Contributor

Documentation Preview

No regression tested rules have been changed.

(comment created at 2026-04-05 19:13:43+00:00 for 91ee33c)

@UncleOwen
UncleOwen marked this pull request as ready for review April 5, 2026 19:13
@adangel adangel changed the title [dist] Various small changes to AntIT.java: [dist] chore: Improve error message for missing JAVA_HOME in AntIT.java Apr 7, 2026
@adangel adangel added this to the 7.24.0 milestone Apr 7, 2026

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel added the in:pmd-internals Affects PMD's internals label Apr 7, 2026
adangel added a commit that referenced this pull request Apr 7, 2026
@adangel
adangel merged commit 91ee33c into pmd:main Apr 7, 2026
12 checks passed
@UncleOwen
UncleOwen deleted the antit-fixes branch April 16, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:pmd-internals Affects PMD's internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants