Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #576
This PR fixes two dialect issues uncovered in #569 but shelved until that was done. The issues are
T-SQL: Only allow ORDER BY in the outermost query. DRAW line encoded it in a nested query. This was fixed not by changing the dialect but by changing the stat to hoist the order by up
MySQL: Only allows a single reference to a temp table per query. Boxplot et al violated that in its quantile computations. This turned out to be unfixable in the query generation and instead MySQL now opts out of temp table generation (together with MS SQL and Oracle). As the list have now grown, I've added a cleanup step to these so that, unless the process errors out mid-execution, we don't leave tables hanging.