Make pre-commit consider a hook as "failed" if it modifies files and still (incorrectly?) exits 0 #285

Activity

1. asottile

   added

   feature

   on Nov 12, 2015
2. asottile

   added a commit that references this issue on Nov 12, 2015

   Fail a hook if it makes modifications. Resolves #285

   This issue will close once commit a3f78bc is merged into the 'main' branch.

   a3f78bc
3. asottile

   closed this as completedin a3f78bcon Nov 13, 2015
4. asottile

   added a commit that references this issue on Nov 13, 2015

   Merge pull request #287 from pre-commit/fail_modifying_hooks_285

   ...

   This issue will close once commit 560d28e is merged into the 'main' branch.

   560d28e
5. David2011Hernandez commented on Mar 18, 2025

   

   David2011Hernandez

   on Mar 18, 2025

   More actions

   It is possible to "disable" this behavior for a specific hook?
6. asottile commented on Mar 18, 2025

   

   asottile

   on Mar 18, 2025

   MemberAuthor

   More actions

   no, there's no reason that would be a desirable behavior

   👎React with 👎1Reacted by combatopera
7. David2011Hernandez commented on Mar 18, 2025

   

   David2011Hernandez

   on Mar 18, 2025

   More actions

   I went through different closed old PRs and comments regarding this topic. Maybe I should have done before writing XD

   But thanks for answering