You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update codegen to use mangled names in exports? #2847
Perhaps instead we should use the same name in the exports that we have locally:
module.exports = { foo$prime: foo$prime }
This applies to any mangling, $prime was just an example, there are a bunch of other cases too.
This would fix a whole bunch of warnings that rollup-plugin-purs spits out, and would match the behaviour that we'll eventually use for ES6 modules whenever that happens.
Do we have an issue open for something like this already? I vaguely remember something about changing mangling to help with a future switchover to ES6.
Activity
paf31 commentedon Apr 15, 2017
I'd be happy to do this at the same time we move to ES6, since I think the current behavior is slightly nicer from the JS side.
hdgarrood commentedon Apr 15, 2017
Do we have an issue open for something like this already? I vaguely remember something about changing mangling to help with a future switchover to ES6.
garyb commentedon Apr 15, 2017
@hdgarrood you're right, #2558 - I thought it was tucked away in one of the mega-ES6-discussion threads