Skip to content

[purs ide] Add a new namespace filter #2792 - #2892

Closed
sectore wants to merge 1 commit into
purescript:masterfrom
sectore:purs-ide-namespace-parsing
Closed

[purs ide] Add a new namespace filter #2792#2892
sectore wants to merge 1 commit into
purescript:masterfrom
sectore:purs-ide-namespace-parsing

Conversation

@sectore

@sectore sectore commented May 14, 2017

Copy link
Copy Markdown
Contributor
  • Implementing the filtering logic
  • Parsing the new filter as JSON
  • Tests

@kritzcreek Any feedback are very welcome, not just because it's my first contribution to purescript/purescript :)

@sectore
[purs ide] Add a new namespace filter #2792
98eefb7 
- Implementing the filtering logic
- Parsing the new filter as JSON
- Tests
@sectore sectore mentioned this pull request May 14, 2017
Closed
@kritzcreek

kritzcreek commented May 14, 2017

Copy link
Copy Markdown
Member

Hey @sectore thank you so much for the PR! We've run into a bit of an awkward situation with #2893 here. If the two of you are up for it I'd like to cherry pick the best of the two PR's and make this a combined first contribution?

Your documentation in PROTOCOL.md is excellent and you added extensive tests so I'd like to keep those 👍 Maybe you could PR these changes onto @stefanholzmueller's branch and add yourself to CONTRIBUTORS.md while you're at it? I prefer Stefan's implementation of the logic and would like to keep it. If you want I'd still be thrilled to review your PR and comment where I would've asked for changes.

sectore added a commit to stefanholzmueller/purescript that referenced this pull request May 15, 2017
@sectore
Pick content from PR purescript#2892
6d747df 
- Add more tests
- Update `PROTOCOL.md`
- Update `CONTRIBUTORS.ms`
@sectore

sectore commented May 15, 2017

Copy link
Copy Markdown
Contributor Author

PR can be closed now. As suggested by @kritzcreek some things have been merged into #2893.

Thanks again for your great collaboration @stefanholzmueller! That's really fun 😃

@sectore sectore closed this May 15, 2017
@sectore
sectore deleted the purs-ide-namespace-parsing branch May 15, 2017 18:50
kritzcreek pushed a commit that referenced this pull request May 16, 2017
@stefanholzmueller @kritzcreek
[purs ide] Add a new namespace filter (#2792) (#2893)
65e4b74 
* [purs ide] Add a new namespace filter (#2792)

* Pick content from PR #2892

- Add more tests
- Update `PROTOCOL.md`
- Update `CONTRIBUTORS.ms`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sectore @kritzcreek