Skip to content

Fix workflows failing when trying to set draft status - #2589

Merged
yguclu merged 6 commits into
develfrom
ebourne_ci_permissions
Mar 10, 2026
Merged

yguclu merged 6 commits into
develfrom
ebourne_ci_permissions

Conversation

@EmilyBourne

@EmilyBourne EmilyBourne commented Mar 10, 2026 •

Copy link
Copy Markdown
Member

Set contents:write permission as indicated by cli/cli#8910 to fix workflows failing when trying to set draft status. Save conclusion to outputs instead of only outputting it to the terminal.


Pull request checklist

Please tick off items when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Ensure you appear in the AUTHORS file
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update CHANGELOG.md
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@yguclu yguclu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

Comment thread .github/workflows/pr_clean_up.yml Outdated
@github-actions
github-actions Bot marked this pull request as draft March 10, 2026 22:03
@EmilyBourne
EmilyBourne requested a review from yguclu March 10, 2026 22:40
@EmilyBourne
EmilyBourne marked this pull request as ready for review March 10, 2026 22:40

@yguclu yguclu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Let's see if everything works out after merging

@github-actions github-actions Bot added the Ready_to_merge Approved by senior developer. Ready for final approval and merge label Mar 10, 2026
@yguclu yguclu changed the title More workflow improvements Fix workflows failing when trying to set draft status Mar 10, 2026
@yguclu
yguclu enabled auto-merge (squash) March 10, 2026 22:50

@pyccel-bot pyccel-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@yguclu
yguclu merged commit 5b56b10 into devel Mar 10, 2026
31 checks passed
@yguclu
yguclu deleted the ebourne_ci_permissions branch March 10, 2026 23:53
EmilyBourne added a commit that referenced this pull request Mar 11, 2026
Set `contents:write` permission as indicated by
cli/cli#8910 to fix workflows failing when
trying to set draft status. Save conclusion to outputs instead of only
outputting it to the terminal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready_to_merge Approved by senior developer. Ready for final approval and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants