Repository navigation
Make default style meet WCAG AA - #1940
Merged
Merged
Conversation
Accessibility by default is important. The colors with a too low contrast were adjusted just so much that they match the required contrast of 4.5. Part of pygments#1718.
5 of 7 tasks
Collaborator
|
Thanks for preparing this! I'll fix the lineos update. Do you happen to have a before/after screenshot for the default style? |
Contributor
Author
|
Yeah, I added screenshots for all changed colors. |
Collaborator
|
Thanks a lot. That is much more subtle than I expected. |
Member
|
Indeed, thanks a lot! |
Contributor
Author
|
You're welcome :) Once this is merged, I'll proceed with the steps I outlined in #1718. |
Collaborator
|
Merged, thanks a lot. Pray continue. |
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Dec 11, 2021
To increse accessiblity of our docs, this changes the pygments_theme of sphinx-docs.org to "default". It was updated to meet WCAG AA in pygments/pygments#1940.
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Dec 11, 2021
…lity To increse accessiblity of our docs, this changes the pygments_theme of sphinx-docs.org to "default". It was updated to meet WCAG AA in pygments/pygments#1940.
Ast-x64
added a commit
to Ast-x64/diff_cover
that referenced
this pull request
Jan 26, 2022
The pygments module made a change to default snippet styles in 2.11.0,
which breaks the test_style_defs unit here using predefined styles
from old pygments.
See pygments/pygments#1940 for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessibility by default is important.
The colors with a too low contrast were adjusted just
so much that they match the required contrast of 4.5.
Part of #1718.
tests/html_linenos_expected_outputsomehow needs to be updated for the tests to pass ... but I don't know how.Screenshots
Before:
After:
Before:
After:
Before:
After:
Before:
After:
Before:
After:
Before:
After:
Before:
After:
Before:
After: