Repository navigation
Python crashes on macOS after fork with no exec #77906
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2020-05-29.18:09:22.220>
created_at = <Date 2018-06-01.00:53:06.418>
labels = ['OS-mac', '3.8', 'type-crash']
title = 'Python crashes on macOS after fork with no exec'
updated_at = <Date 2021-11-04.14:32:41.053>
user = 'https://github.com/kapilt'bugs.python.org fields:
activity = <Date 2021-11-04.14:32:41.053>
actor = 'eryksun'
assignee = 'none'
closed = True
closed_date = <Date 2020-05-29.18:09:22.220>
closer = 'barry'
components = ['macOS']
creation = <Date 2018-06-01.00:53:06.418>
creator = 'kapilt'
dependencies = []
files = []
hgrepos = []
issue_num = 33725
keywords = ['patch']
message_count = 70.0
messages = ['318352', '318361', '318396', '318397', '318528', '318529', '318708', '329871', '329880', '329885', '329919', '329922', '329923', '329926', '329927', '329933', '329941', '331101', '331406', '331407', '331409', '331411', '331435', '331438', '331459', '331610', '331733', '331735', '337587', '337591', '337733', '338819', '338873', '341452', '341455', '341475', '342042', '342071', '342412', '343704', '343773', '343779', '343782', '343807', '343826', '343828', '343830', '343832', '343833', '343838', '343841', '343842', '343844', '343895', '343898', '344590', '344608', '344710', '344762', '344763', '345841', '365249', '365251', '365252', '365262', '365263', '365266', '365281', '370296', '370331']
nosy_count = 2.0
nosy_names = ['ronaldoussoren', 'ned.deily']
pr_nums = ['11043', '11044', '11045', '13603', '13626', '13841', '13849']
priority = 'critical'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue33725'
versions = ['Python 3.8']
Activity
kapilt commentedon Jun 1, 2018
This issue seems to be reported a few times on various githubs projects. I've also reproduced using a brew install of python 2.7.15. I haven't been able to reproduce with python 3.6. Note this requires a framework build of python.
Background on the underlying issue cause due to a change in high Sierra
http://sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html
A ruby perspective on the same issue exhibiting for some apps
https://blog.phusion.nl/2017/10/13/why-ruby-app-servers-break-on-macos-high-sierra-and-what-can-be-done-about-it/
The work around seems to be setting an environment variable OBJC_DISABLE_INITIALIZE_FORK_SAFETY prior to executing python.
Other reports
https://bugs.python.org/issue30837
ansible/ansible#32499
MikeChongCan/scylla#22
elastic/beats-tester#73
jhaals/ansible-vault#60
ronaldoussoren commentedon Jun 1, 2018
A better solution is to avoid using fork mode for multiprocessing. The spawn and fork server modes should work fine.
The underlying problem is that macOS system frameworks (basically anything higher level than libc) are not save wrt fork(2) and fixing that appears to have no priority at all at Apple.
ned-deily commentedon Jun 1, 2018
(As a side note, the macOS Pythons provided by python.org installers should not behave differently on macOS 10.13 High Sierra since none of them are built with a 10.13 SDK.)
pitrou commentedon Jun 1, 2018
I understand that Apple, with their limited resources, cannot spend expensive engineer manpower on improving POSIX support in macOS </snark>.
In any case, I'm unsure this bug can be fixed at the Python level. If macOS APIs don't like fork(), they don't like fork(), point bar. As Ronald says, on 3.x you should use "forkserver" (for multiple reasons, not only this issue). On 2.7 you're stuck dealing with the issue by yourself.
ronaldoussoren commentedon Jun 3, 2018
Antoine, the issue is not necessarily related to POSIX compliance, AFAIK strictly POSIX compliant code should work just fine. The problem is in higher-level APIs (CoreFoundation, Foundation, AppKit, ...), and appears to be related to using multi-threading in those libraries without spending effort on pre/post fork handlers to ensure that new processes are in a sane state after fork(). In older macOS versions this could result in hard to debug issues, in newer versions APIs seem to guard against this by aborting when the detect that the pid changed.
Anyways... I agree that we shouldn't try to work around this in CPython, there's bound to more problems that are hidden with the proposed workaround.
---
<http://www.sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html\> describes what the environment variable does, and this "just" changes behavior of the ObjC runtime, and doesn't make using macOS system frameworks after a fork saver.
ronaldoussoren commentedon Jun 3, 2018
@ned: In the long run the macOS installers should be build using the latest SDK, primarily to get full API coverage and access to all system APIs.
AFAIK building using the macOS 10.9 SDK still excludes a number of libSystem APIs that would be made available through the posix module when building with a newer SDK.
That's something that would require some effort though to ensure that the resulting binary still works on older versions of macOS (basically similar to the work I've done in the post to weak link some other symbols in the posix module).
ned-deily commentedon Jun 4, 2018
{Note: this is not particularly relevant to the issue here.)
Ronald:
I agree that being able to build with the latest SDK would be nice but it's also true it would require effort on our part, both one-time and ongoing, at least for every new macOS SDK release and update to test with each older system. It would also require that the third-party libraries we build for an installer also behave correctly. And to make full use of it, third-party Python packages with extension modules would also need to behave correctly. I see one of the primary use cases for the python.org macOS installers as being for Python app developers who want to provide apps that run on a range of macOS releases. It seems to me that the safest and simplest way to guarantee that python.org macOS Pythons fulfill that need is to continue to always build them on the oldest supported system. Yes, that means that users may miss out on a few features only supported on the more recent macOS releases but I think that's the right trade-off until we have the resources to truly investigate and decide to support weak linking from current systems.
warsaw commentedon Nov 13, 2018
bpo-35219 is where I've run into this problem. I'm still trying to figure out all the details in my own case, but I can confirm that setting the environment variable does not always help.
[-]High Sierra hang when using multi-processing[/-][+]macOS crashes after fork with no exec[/+][-]macOS crashes after fork with no exec[/-][+]Pytho crashes on macOS after fork with no exec[/+][-]Pytho crashes on macOS after fork with no exec[/-][+]Python crashes on macOS after fork with no exec[/+]warsaw commentedon Nov 14, 2018
Hoo boy. I'm not sure I have the full picture, but things are starting to come into focus. After much debugging, I've narrowed down at least one crash to urllib.request.getproxies(). On macOS (darwin), this ends up calling _scproxy.get_proxies() which calls into the SystemConfiguration framework. I'll bet dollars to donuts that that calls into the ObjC runtime. Thus it is unsafe to call between fork and exec. This certainly seems to be the case even if the environment variable is set.
The problem is that I think requests.post() probably also ends up in here somehow (still untraced), because by removing our call to urllib.requests.getproxies(), we just crash later on when requests.post() is called.
I don't know what, if anything can be done in Python, except perhaps to document that anything that calls into the ObjC runtime between fork and exec can potentially crash the subprocess.
66 remaining items
Use platform dependent start method
Handle platform dependent start method
Handle platform dependent start method (#179)
Set Python multiprocess launch method to be fork
Support non-"fork" multiprocessing start methods.