Repository navigation
gh-112414: Add additional unit tests for calling repr() on a namespace package - #112475
Merged
Merged
Conversation
…namespace package
AlexWaygood
added
skip news
topic-importlib
needs backport to 3.12
Member
Removing that test makes sense, since the test you add here covers that bit and the former is a bit out of place. |
ericsnowcurrently
requested changes
Nov 27, 2023
|
When you're done making the requested changes, leave the comment: |
AlexWaygood
requested review from
brettcannon,
ncoghlan and
warsaw
as code owners
November 27, 2023 23:48
Co-authored-by: Eric Snow <[email protected]>
…rily Co-authored-by: Eric Snow <[email protected]>
Member
Author
|
Thanks! I have made the requested changes; please review again |
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2023
…namespace package (pythonGH-112475) (cherry picked from commit cf20540) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Eric Snow <[email protected]>
|
GH-112480 is a backport of this pull request to the 3.12 branch. |
Member
|
Thanks for working on this, @AlexWaygood! |
Member
Author
|
You're very welcome! :D |
AlexWaygood
added a commit
that referenced
this pull request
Nov 28, 2023
… namespace package (GH-112475) (#112480) gh-112414: Add additional unit tests for calling `repr()` on a namespace package (GH-112475) (cherry picked from commit cf20540) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Eric Snow <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…namespace package (python#112475) Co-authored-by: Eric Snow <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…namespace package (python#112475) Co-authored-by: Eric Snow <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing @ericsnowcurrently's post-merge review at #112425 (comment). I've verified locally that the second test here fails if you build CPython with e954ac7 (the commit prior to 0622839).
@ericsnowcurrently, would you also like me to remove the test I added in 0622839, or is that okay to stay? :)
ModuleType.__repr__can fail on py312+ #112414