Skip to content

Better handling of generic functions in partial plugin - #17925

Merged
hauntsaninja merged 2 commits into
python:masterfrom
ilevkivskyi:fix-partial-generic
Oct 14, 2024
Merged

hauntsaninja merged 2 commits into
python:masterfrom
ilevkivskyi:fix-partial-generic

Conversation

@ilevkivskyi

Copy link
Copy Markdown
Member

Fixes #17411

The fix is that we remove type variables that can never be inferred from the initial check_call() call. Actual diff is tiny, I just moved a bunch of code, since I need formal to actual mapping sooner now.

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja
hauntsaninja merged commit 1a074b6 into python:master Oct 14, 2024
JukkaL pushed a commit that referenced this pull request Oct 14, 2024
Fixes #17411

The fix is that we remove type variables that can never be inferred from
the initial `check_call()` call. Actual diff is tiny, I just moved a
bunch of code, since I need formal to actual mapping sooner now.
@ilevkivskyi
ilevkivskyi deleted the fix-partial-generic branch October 14, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

functools.partial incorrectly handles constrained generic function arguments

2 participants