add mypyc.analysis to setup.py - #9587
Merged
Merged
Conversation
Fixes #9584 I haven't tested myself but this package should probably be here.
TH3CHARLie
approved these changes
Oct 13, 2020
TH3CHARLie
left a comment
TH3CHARLie
left a comment
Collaborator
There was a problem hiding this comment.
feel free to merge when all tests are green
Collaborator
|
Do we need a new release (or changes to MANIFEST.in)? I think something similar to this happened with 0.78* (see #8949 ) |
Member
Author
|
I added it to MANIFEST.in too, that seems like we'd need it. I'm basically just cargo-culting here though, and I don't have time at the moment to look deeper and get a better understanding of what's going on. |
Closed
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Oct 13, 2020
Is there a reason to not do this? It gets the right set of packages when I run it. Saves chores like python#9587 or python#9061
msullivan
pushed a commit
that referenced
this pull request
Oct 18, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9584
I haven't tested myself but this package should probably be here.