Skip to content

Rearrange overloads to account for optional arguments - #2150

Merged
JelleZijlstra merged 2 commits into
python:masterfrom
Michael0x2a:rearrange-overloads-2
May 19, 2018
Merged

JelleZijlstra merged 2 commits into
python:masterfrom
Michael0x2a:rearrange-overloads-2

Conversation

@Michael0x2a

Copy link
Copy Markdown
Contributor

Basically, the same thing as my previous pull request, except the fixes are now focusing on functions with overlapping argument counts.

Basically, the same thing as [my previous pull request][0], except the
fixes are now focusing on functions with overlapping argument counts.

  [0]: python#2138
Comment thread stdlib/2/os/path.pyi

@overload
def relpath(path: _StrPath, start: Optional[_StrPath] = ...) -> Text: ... # type: ignore
def relpath(path: _BytesPath, start: _BytesPath) -> bytes: ... # type: ignore

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you apply the same ordering change to stdlib3/os/path.pyi?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mkay, done.

@JelleZijlstra
JelleZijlstra merged commit 709b193 into python:master May 19, 2018
@Michael0x2a
Michael0x2a deleted the rearrange-overloads-2 branch May 20, 2018 15:35
Michael0x2a added a commit to Michael0x2a/mypy that referenced this pull request May 20, 2018
This time mostly to incorporate python/typeshed#2150
Michael0x2a added a commit to python/mypy that referenced this pull request May 20, 2018
This time mostly to incorporate python/typeshed#2150.
gwk pushed a commit to gwk/typeshed that referenced this pull request May 29, 2018
Basically, the same thing as [my previous pull request][0], except the
fixes are now focusing on functions with overlapping argument counts.

  [0]: python#2138
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
Basically, the same thing as [my previous pull request][0], except the
fixes are now focusing on functions with overlapping argument counts.

  [0]: python#2138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants