Repository navigation
session: Fix API leak pt2 - #203
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 2192 2192
=========================================
Hits 2192 2192 ☔ View full report in Codecov by Sentry. |
Merged
crobinso
force-pushed
the
fix-api-key-leak2
branch
from
February 8, 2024 19:01
43a8690 to
fe50a18
Compare
Between the time 182e0b0 was written, 138caf8 was committed which inadvertently loosened up the api_key scraping. Go back to catching `Exception` so we try harder to scrape api_key from error messages. Signed-off-by: Cole Robinson <[email protected]>
Signed-off-by: Cole Robinson <[email protected]>
crobinso
force-pushed
the
fix-api-key-leak2
branch
from
February 13, 2024 19:32
fe50a18 to
2960d81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session: Fix API leak pt2
Between the time 182e0b0 was written, 138caf8 was committed
which inadvertently loosened up the api_key scraping.