Repository navigation
code clean - #616
Closed
dvska wants to merge 1 commit into
Closed
code clean#616dvska wants to merge 1 commit into
dvska wants to merge 1 commit into
Conversation
Member
There was a problem hiding this comment.
This change is an actual functional change. It may well be correct, but I'd like to see a test that is broken and fixed for this one, and the similar one on line 125.
Member
|
@dvska Any plans to fix this PR? I will close, otherwise. Thanks |
Closed
Member
|
PR #626 contains a broken and fixed test for line 48. I couldn't reproduce line 125. It just needs a test file that hits that line when opened. |
Member
|
So, I think what I'm going to do here is cherry pick some of the code clean changes for merging. Some of the things that I'm not going to pick are:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.