Repository navigation
Conversation
Closed
Member
|
Thanks @hugovk. Somewhere in the openjpeg documentation, I think I saw a set of sample images. Not sure that I'd want to use them all, as they were many times the size of our project. We might be able to use one/several of those to improve our test coverage. |
Member
Author
|
Thanks, I found some at http://www.openjpeg.org/index.php?menu=samples In another branch, I added the smallish Bretagne1.j2k (90 KB) and Cevennes2.jp2 (18 KB) but both are RGB and not RGBA so they didn't hit line 125. They increased the coverage by a single line. But I don't know the copyright status -- are they ok? The others on that page are probably too big, so I didn't try them: Bretagne2.j2k (5 MB), Cevennes1.j2k (1.5 MB) and Rome.jp2 (379 KB). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #616 to clean code includes two functional changes (
==that should be=) but without tests (requested by @wiredfool).Here's a test for the first one (line 48) that fails before any changes, and passes with
==changed to=:Failing build: https://travis-ci.org/hugovk/Pillow/jobs/22942098
Passing build: https://travis-ci.org/hugovk/Pillow/jobs/22942992
I added two test images, created with ImageMagick on Windows. This fix is with the .j2k file. I was hoping the .jp2 would cover the other one but it didn't. *
I think the test images should be renamed somehow. Suggestions?
Please can someone else create a test .jp2 file for the other case? It needs to hit line 125.
* When I did some testing (on Windows), the .jp2's signature is different.
\x00\x00\x00\x0cjP \n\x87\n\x00\x00\x00\x00\x0cjP \x0d\x0a\x87\x0a(line 145)