Repository navigation
Clean up preprocessor cruft for Windows - #652
Merged
Merged
Conversation
1) Renamed USE_INLINE to PIL_USE_INLINE to avoid conflicts with
other headers/libraries.
2) Replace __WIN32__ and WIN32 with _WIN32
3) Don't define WIN32 when the compiler is MSVC but not on Windows
Why would you even...
4) Don't define strcasecmp if you're not even going to use it.
5) Don't include Windows.h with undefs for compilers newer than
1998 everywhere.
6) Don't surpress warnings for MSVC++ 4.0. People still using
MSVC++ 4.0 deserve it.
7) Don't include things that are already included in Windows.h
Member
|
Thanks for going through this. I'll take a look, and ping @cgohlke as well. FWIW, officially, we don't care (anymore) about anything that predates Python 2.6, which would be MSVC 2008. |
Contributor
|
Using msvc10, I needed to replace |
Member
Contributor
|
#643 LGTM. Same as CounterPillow#1 |
Contributor
Author
|
Any news on this? |
aclark4life
added a commit
that referenced
this pull request
May 14, 2014
Clean up preprocessor cruft for Windows
Member
|
Thanks |
Contributor
Author
|
You'll also need to merge #643 for this to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
other headers/libraries.
__WIN32__andWIN32with_WIN32Why would you even...
Addresses issue #642 and together with PR #643 fixes building on mingw-w64, and thus, issue #642
I have tested this with mingw-w64.
Anyone willing to test this with MSVC is more than welcome to.